Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dispatch_deadline parameter to tasks_v2.Task #60

Merged
merged 2 commits into from
Jan 29, 2025
Merged

feat: add dispatch_deadline parameter to tasks_v2.Task #60

merged 2 commits into from
Jan 29, 2025

Conversation

frnsimoes
Copy link
Member

No description provided.

frnsimoes
frnsimoes commented Jan 23, 2025
View reviewed changes
gcp_pilot/tasks.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 23, 2025 •
edited
Loading

Coverage Status

coverage: 29.362% (-0.02%) from 29.383%
when pulling 227aa6e on feat/add-dispatch-deadline-to-tasks
into 933a112 on main.

rodrigoalmeidaee
rodrigoalmeidaee reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@rodrigoalmeidaee rodrigoalmeidaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precisa fazer o version bump no pyproject.toml 😛

Depois preciso descobrir se esse negócio auto publica uma nova versão depois do merge igual as nossas libs ou não 😅

@frnsimoes frnsimoes force-pushed the feat/add-dispatch-deadline-to-tasks branch 2 times, most recently from 8a98a26 to 908e765 Compare January 29, 2025 14:18
@frnsimoes frnsimoes force-pushed the feat/add-dispatch-deadline-to-tasks branch from 908e765 to 227aa6e Compare January 29, 2025 14:21
@frnsimoes frnsimoes merged commit edf3f4b into main Jan 29, 2025
11 of 12 checks passed
@frnsimoes frnsimoes deleted the feat/add-dispatch-deadline-to-tasks branch January 29, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegodfreire diegodfreire diegodfreire approved these changes

@rodrigoalmeidaee rodrigoalmeidaee Awaiting requested review from rodrigoalmeidaee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frnsimoes @coveralls @rodrigoalmeidaee @diegodfreire